Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jointcal metrics and specifications tickets/DM-9542 #3

Merged
merged 2 commits into from
Mar 16, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
88 changes: 88 additions & 0 deletions metrics/jointcal.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# validate_drp metric definitions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probs want to change this comment.

# Definitions from LPM-17 (the Science Requirements Document).
# http://ls.st/lpm-17

associated_astrometry_fittedStars:
description: >
The number of cross-matched fittedStars for astrometry.
unit: ''
tags: astrometry

collected_astrometry_refStars:
description: >
The number of astrometry reference stars drawn from the reference catalog, before matching.
unit: ''
tags: astrometry

selected_astrometry_refStars:
description: >
The number of astrometry reference stars matched to fittedStars.
unit: ''
tags: astrometry

selected_astrometry_fittedStars:
description: >
The number of cross-matched fittedStars after cleanup, for astrometry.
unit: ''
tags: astrometry

selected_astrometry_ccdImages:
description: >
The number of ccdImages that will be fit for astrometry, after cleanup.
unit: >
tags: astrometry

astrometry_chisq:
description: >
The final chi2 of the astrometry fit.
unit: ''
tags: astrometry

astrometry_ndof:
description: >
The number of degrees of freedom of the fitted astrometry.
unit: ''
tags: astrometry


associated_photometry_fittedStars:
description: >
The number of cross-matched fittedStars for photometry.
unit: ''
tags: photometry

collected_photometry_refStars:
description: >
The number of photometry reference stars drawn from the reference catalog, before matching.
unit: ''
tags: photometry

selected_photometry_refStars:
description: >
The number of photometry reference stars matched to fittedStars.
unit: ''
tags: photometry

selected_photometry_fittedStars:
description: >
The number of cross-matched fittedStars after cleanup, for photometry.
unit: ''
tags: photometry

selected_photometry_ccdImages:
description: >
The number of ccdImages that will be fit for photometry, after cleanup.
unit: >
tags: photometry

photometry_chisq:
description: >
The final chi2 of the photometry fit.
unit: ''
tags: photometry

photometry_ndof:
description: >
The number of degrees of freedom of the fitted photometry.
unit: ''
tags: photometry
5 changes: 5 additions & 0 deletions specs/jointcal/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
##################
specs/jointcal
##################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the under/overline are the same length as the text.


Specifications for ``jointcal`` metrics are defined in this directory as YAML documents.
29 changes: 29 additions & 0 deletions specs/jointcal/astrometry_chisq.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Astrometry Chi-squared specifications.

# These specifications don't query against provenance; sub-specifications
# *can* inherit these, though, to concretely test against a certain dataset.

---
# Specification partial
id: 'astrometry_chisq-base'
metric: 'astrometry_chisq'
threshold:
operator: "<="

---
name: "maximum"
base: "#astrometry_chisq-base"
threshold:
value: 5.0

---
name: "safe"
base: "#astrometry_chisq-base"
threshold:
value: 1.5

---
name: "low"
base: "#astrometry_chisq-base"
threshold:
value: 0.5
8 changes: 8 additions & 0 deletions specs/jointcal/astrometry_ndof.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Astrometry degrees of freedom specifications.

---
# Specification partial
id: 'astrometry_ndof-base'
metric: 'astrometry_ndof'
threshold:
operator: "=="
42 changes: 42 additions & 0 deletions specs/jointcal/hsc_r.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Specifications for jointcal metrics against testdata_jointcal
# hsc r-band datasets.

---
id: 'base'
provenance_query:
# Prototype for query provenance. This needs to be figured out.
dataset_repo_url: 'https://github.com/lsst/testdata_jointcal.git'

---
# jointcal.astrometry_ndof.hsc_11_visits
name: "hsc_11_visits"
base: ["#astrometry_ndof-base", "#base"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the syntax here will be 'astrometry_ndof.yaml#astrometry_ndof-base' to help resolve that partial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've cleaned that up, and touched up the rest of this file too. I think these specifications are going to have to remain placeholders until we have Specification working, with a linter.

provenance_query:
# Prototype for query provenance. This needs to be figured out.
visits: [903334, 903336, 903338, 903342, 903344, 903346, 903986, 903988, 903990, 904010, 904014]
config: 'config.astrometryModel="simplePoly"'
threshold:
value: 14262

---
# jointcal.astrometry_ndof.hsc_2_visits
name: "hsc_2_visits"
base: ["#astrometry_ndof-base", "#base"]
provenance_query:
# Prototype for query provenance. This needs to be figured out.
dataset_repo_url: 'https://github.com/lsst/testdata_jointcal.git'
visits: [903334, 903336]
config: 'config.astrometryModel="simplePoly"'
threshold:
value: 1858

---
# jointcal.astrometry_chisq.hsc_2_visits
name: "hsc_2_visits"
base: ["#astrometry_chisq-base", "#base"]
provenance_query:
# Prototype for query provenance. This needs to be figured out.
dataset_repo_url: 'https://github.com/lsst/testdata_jointcal.git'
visits: [903334, 903336]
config: 'config.astrometryModel="simplePoly"'