Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artax support #16

Closed
staabm opened this issue Oct 6, 2014 · 6 comments · Fixed by #17
Closed

Artax support #16

staabm opened this issue Oct 6, 2014 · 6 comments · Fixed by #17

Comments

@staabm
Copy link

staabm commented Oct 6, 2014

Any chance to get support for the artax http client?

https://github.com/amphp/artax

@lstrojny
Copy link
Owner

lstrojny commented Oct 6, 2014

You mean as a blocking version?

lstrojny added a commit that referenced this issue Oct 6, 2014
@lstrojny
Copy link
Owner

lstrojny commented Oct 6, 2014

Have a look at the references pull request if that is what you expect.

@staabm
Copy link
Author

staabm commented Oct 7, 2014

This looks like a good start, thx. Asynchronous calls are not supported right now, right?

@lstrojny
Copy link
Owner

lstrojny commented Oct 7, 2014

The API of fxmlrpc is inherently synchronous so I don’t see a way right now. An option could be to introduce Promise AsynchronousClientInterface::call(string $method, array $arguments) but I’m not sure it’s worth for a single adapter.

@staabm
Copy link
Author

staabm commented Oct 7, 2014

I see. Until you really decide to support Async calls, its great as is.
Hopefully PSR-7 will land in the near future, which would make things for you easier.
https://github.com/php-fig/fig-standards/blob/master/proposed/http-message-meta.md
https://github.com/php-fig/fig-standards/blob/master/proposed/http-message.md

Note: I did not test the code of the PR

lstrojny added a commit that referenced this issue Oct 7, 2014
lstrojny added a commit that referenced this issue Oct 7, 2014
@lstrojny
Copy link
Owner

lstrojny commented Oct 7, 2014

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants