Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0 #96

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

E-Fir
Copy link
Member

@E-Fir E-Fir commented Feb 15, 2021

No description provided.

@@ -6,17 +6,20 @@
- `COPYRIGHT` file;
- `_COPYRIGHT` exported constant in the main module.
3. Update version in `_VERSION` exported constant in the main module.
4. Regenerate exports list (performed by `./make.sh`)
5. Generate `scm-1` rockspec (performed by `./make.sh`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

принято, влить

Lua up to 5.4 support is added.

make.sh:
More strict bash is set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

непонятно, что хотели сказать

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не знаю, commit message такой make.sh: more strict bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

убери под catch all (в смысле "и прочие мелкие правки везде")

Updating list-exports only if a rock is installed.
Allow local luarocks installation with "--local" option.

datetime-utils (new module):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вижу, что в RELEASE не написано про использование git shortlog для составления записи в этом файле. Надо написать.

Ты же им пользовался, да?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я (как бы) им пользовался как рефернсом (gitk)

Вывод из git shortlog выглядит не подходящим под стиль описания прошлых версий.

Может я просто не знаю как им правильно пользоваться.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

из слака:
AR> git shortlog — как правильно пользоваться?
AG>git shortlog v1.0.0...

выдаёт море коммитов

я никогда не пользовался раньше, что имеется ввиду под его использованием конкретно?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай обсудим в слаке. мне пока непонятна проблематика

@@ -7,7 +7,7 @@ and commercial purposes at absolutely no cost.

===============================================================================

Copyright (C) 2009-2017 Lua-Núcleo authors
Copyright (C) 2009-2021 Lua-Núcleo authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

принято, влить

лучше одним коммитом все места с годами обновить

@@ -9,7 +9,7 @@ Alexander V. Nikolaev <avn@daemon.hole.ru>
Valeriy Skurikhin <Keen.vs@gmail.com>
Vladimir Dronnikov <dronnikov@gmail.com>
Alexander Altshuler <altexy@gmail.com>
Alexey Romanov <jobmail37@gmail.com>
Alexey Romanoff <vr@alexeyromanoff.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

принято, влить

@@ -9,7 +9,7 @@ Alexander V. Nikolaev <avn@daemon.hole.ru>
Valeriy Skurikhin <Keen.vs@gmail.com>
Vladimir Dronnikov <dronnikov@gmail.com>
Alexander Altshuler <altexy@gmail.com>
Alexey Romanov <jobmail37@gmail.com>
Alexey Romanoff <vr@alexeyromanoff.com>
Rafis Ganeyev <rafisganeyev@gmail.com>
Mark Gurevich <markgurevichster@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

проверь плз, опираясь на запрос в гит, что все авторы есть

и напиши этот запрос в RELEASE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

что все авторы есть где? в истории коммитов?

Copy link
Member

@agladysh agladysh Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

что все авторы из истории коммитов есть в AUTHORS

{
type = 'cases';
path = 'test/cases/0650-enumerator.lua';
};
{
type = 'cases';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ГК

unpack_timestamp =
{
{ "lua-nucleo/timestamp.lua", w = 0 };
};
upper_bound =
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ГК

@@ -43,6 +45,7 @@ build = {
["lua-nucleo.key_value_store.key_value_store_simple"] = "lua-nucleo/key_value_store/key_value_store_simple.lua";
["lua-nucleo.key_value_store.key_value_store_sophisticated"] = "lua-nucleo/key_value_store/key_value_store_sophisticated.lua";
["lua-nucleo.language"] = "lua-nucleo/language.lua";
["lua-nucleo.legacy"] = "lua-nucleo/legacy.lua";
["lua-nucleo.log"] = "lua-nucleo/log.lua";
["lua-nucleo.math"] = "lua-nucleo/math.lua";
["lua-nucleo.misc"] = "lua-nucleo/misc.lua";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ПП

["lua-nucleo.util.anim.interpolator"] = "lua-nucleo/util/anim/interpolator.lua";
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ПП

@@ -41,6 +41,7 @@ <h2>Modules</h2>
<li><a href="modules/lua-nucleo.code.globals.html">lua-nucleo.code.globals</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ГК

@agladysh
Copy link
Member

Подозрительное:

  1. Не вижу увеличения версии в коде
  2. Вижу изменение годов копирайта только в одном месте, обычно их больше одного

@E-Fir
Copy link
Member Author

E-Fir commented Feb 15, 2021

  1. версия в коде не экспортировалась раньше, это нововведение с этой версии
  2. ещё в _COPYRIGHT было бы, если бы раньше он экспортировался

@agladysh
Copy link
Member

Необходимо в первую очередь вынести коммиты "влить" в отдельный МР.

@E-Fir
Copy link
Member Author

E-Fir commented Apr 22, 2021

Необходимо в первую очередь вынести коммиты "влить" в отдельный МР.

#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants