Correct substituted buildopts.h path strings #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not use XDG_CONFIG_DIRS via g_get_system_config_dirs and xdg.system_config_dirs Also remove an instance of relative paths
To use an xdg system config directory, set CONFIGDIR to /etc/xdg/luakit
Rename repurposed DEVELOPMENT_PATHS as PREFIX_WITH_DESTDIR
|
Thanks for the PR! This looks pretty good; I'll be busy for a few days but will give it a review when I get some free time |
|
I've been testing this and one issue I've discovered is that it breaks tests, which rely on |
c0dev0id
force-pushed
the
develop
branch
5 times, most recently
from
c3824ca
to
4603da9
Compare
c0dev0id
force-pushed
the
develop
branch
2 times, most recently
from
3d40dd2
to
0c32c6b
Compare
|
I think this has been superseded by another PR that fixed DESTDIR. I'll close this 7 year old PR. But feel free to reopen an rebase it on current luakit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows compiling in a work directory and setting the buildopts.h.in paths to the final installed path
Disables relative development paths while keeping DEVELOPMENT_PATHS=1 working