Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DESTDIR in buildopts.h definitions #727

Merged
merged 1 commit into from Nov 16, 2018
Merged

Avoid DESTDIR in buildopts.h definitions #727

merged 1 commit into from Nov 16, 2018

Conversation

iamleot
Copy link
Contributor

@iamleot iamleot commented Oct 6, 2018

Improve DESTDIR support and use it only in install and deinstall target.
The various paths are used in buildopts.h and there having the
DESTDIR is not desiderable.

Improve DESTDIR support and use it only in install and deinstall target.
The various paths are used in buildopts.h and there having the
DESTDIR is not desiderable.
@iamleot
Copy link
Contributor Author

iamleot commented Oct 6, 2018 via email

@c0dev0id c0dev0id self-requested a review November 15, 2018 19:48
Copy link
Member

@c0dev0id c0dev0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test without DESTDIR & PREFIX: ok
Test with DESTDIR & PREFIX: ok
Test with PREFIX: ok
Test with DESTDIR: ok

Also good that the xdg config is placed under DESTDIR.

I'll merge this patch. Thank you!

@c0dev0id c0dev0id merged commit fc07ed5 into luakit:develop Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants