Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in install.bat, produces invalid luarocks.bat and luarocks-admin.bat under certain conditions #1232

Closed
dirkstff opened this issue Oct 13, 2020 · 1 comment
Closed

bug in install.bat, produces invalid luarocks.bat and luarocks-admin.bat under certain conditions #1232

dirkstff opened this issue Oct 13, 2020 · 1 comment

Comments

@dirkstff
Copy link

The bug was introduced by commit 0451337. Now, if vars.COMPILER_ENV_CMD == "", which it can very well be, the line $COMPILER_ENV_CMD >NUL resolves to >NUL, which is a cmd syntax error. Accordingly, luarocks.bat and luarocks-admin.bat fail.
@hishamhm
Copy link
Member

@dwenegar Looks like the issue was introduced by your PR — could you take a look at this, please? Thanks!

@hishamhm hishamhm mentioned this issue Oct 13, 2020
Closed
@vadi2 vadi2 mentioned this issue Nov 20, 2020
Closed
bungle added a commit to Kong/kong that referenced this issue Jan 4, 2021
@bungle
chore(deps) bump luarocks from 3.4.0 to 3.5.0
56cb2cc 
### Summary

- luarocks/luarocks#1229
- luarocks/luarocks#1231
- luarocks/luarocks#1232
- luarocks/luarocks#1233
@bungle bungle mentioned this issue Jan 4, 2021
Merged
bungle added a commit to Kong/kong that referenced this issue Jan 4, 2021
@bungle
chore(deps) bump luarocks from 3.4.0 to 3.5.0 (#6699)
3146a7c 
### Summary

- luarocks/luarocks#1229
- luarocks/luarocks#1231
- luarocks/luarocks#1232
- luarocks/luarocks#1233
kikito pushed a commit to Kong/kong that referenced this issue Jan 6, 2021
@bungle @kikito
chore(deps) bump luarocks from 3.4.0 to 3.5.0 (#6699)
2ed830a 
### Summary

- luarocks/luarocks#1229
- luarocks/luarocks#1231
- luarocks/luarocks#1232
- luarocks/luarocks#1233
locao pushed a commit to Kong/kong that referenced this issue Jan 8, 2021
@bungle @locao
chore(deps) bump luarocks from 3.4.0 to 3.5.0 (#6699)
2acf522 
### Summary

- luarocks/luarocks#1229
- luarocks/luarocks#1231
- luarocks/luarocks#1232
- luarocks/luarocks#1233
@hishamhm hishamhm mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hishamhm @dirkstff