luarocks 2.4.2 fails with a Lua 5.3 variant "no conversion string / number"

[fperrad]

With a lua generated by hererocks with the following command:

hererocks HERE --lua 5.3 --compat default --cflags="-DLUA_NOCVTN2S -DLUA_NOCVTS2N"

The trace with the first error:

...ad/lua-TestMore/HERE/share/lua/5.3/luarocks/fs/tools.lua:123: attempt to concatenate a number value
stack traceback:
	...ad/lua-TestMore/HERE/share/lua/5.3/luarocks/fs/tools.lua:123: in function 'luarocks.fs.use_downloader'
	(...tail calls...)
	...errad/lua-TestMore/HERE/share/lua/5.3/luarocks/fetch.lua:39: in function 'luarocks.fetch.fetch_url'
	...errad/lua-TestMore/HERE/share/lua/5.3/luarocks/manif.lua:95: in upvalue 'fetch_manifest_from'
	...errad/lua-TestMore/HERE/share/lua/5.3/luarocks/manif.lua:137: in function 'luarocks.manif.load_manifest'
	...rrad/lua-TestMore/HERE/share/lua/5.3/luarocks/search.lua:181: in function 'luarocks.search.manifest_search'
	...rrad/lua-TestMore/HERE/share/lua/5.3/luarocks/search.lua:215: in function 'luarocks.search.search_repos'
	...rrad/lua-TestMore/HERE/share/lua/5.3/luarocks/search.lua:307: in function 'luarocks.search.find_suitable_rock'
	...rad/lua-TestMore/HERE/share/lua/5.3/luarocks/install.lua:179: in function 'luarocks.install.command'
	(...tail calls...)
	[C]: in function 'xpcall'
	...ua-TestMore/HERE/share/lua/5.3/luarocks/command_line.lua:187: in function 'luarocks.command_line.run_command'
	/home/travis/build/fperrad/lua-TestMore/HERE/bin/luarocks:34: in main chunk
	[C]: in ?

see the full log on https://travis-ci.org/fperrad/lua-TestMore/jobs/210941896 (Build # 88.6)

[mpeterv]

Fix is trivial and after it most luarocks tests passed with this version of Lua. Unfortunately luasocket and luasec have some issues with it, namely luasocket treats port number as strings internally but its lua module, docs, and luasec use numbers.

[fperrad]

Good enough on Travis CI,
see https://travis-ci.org/fperrad/lua-TestMore/jobs/211427280

[fperrad]

@mpeterv a luasocket fix merged: see lunarmodules/luasocket#211