Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update domain name of mirror (luafr.org -> loadk.com) #1517

Merged
merged 1 commit into from Jul 26, 2023

Conversation

catwell
Copy link
Contributor

@catwell catwell commented Jun 28, 2023

It is the same server, but due to registrar-related changes I probably won't renew the luafr.org domain name. OTOH loadk.com is paid through 2026 and almost certainly not going anywhere after than. :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +5.91 🎉

Comparison is base (9a3c5a8) 79.06% compared to head (3d5a74e) 84.97%.

❗ Current head 3d5a74e differs from pull request most recent head d6fa0e4. Consider uploading reports for the commit d6fa0e4 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   79.06%   84.97%   +5.91%     
==========================================
  Files          89       94       +5     
  Lines       11065    11751     +686     
==========================================
+ Hits         8748     9985    +1237     
+ Misses       2317     1766     -551     
Impacted Files Coverage Δ
src/luarocks/core/cfg.lua 84.50% <ø> (+11.82%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed DNS points to the same server, but a 3rd party could easily do the same. WHOIS data is blocked on both so it's a little hard to confirm anything there. Presumably pointing to the same server combined with the sites themselves both pointing to @catwell's domain make this pretty legit, but if the sever happened to be a shared hosting provider it would be possible for this to be a spoof ;-) Given the trusted GitHub user info here I think we're good, just commenting with my OpSec hat on.

@catwell
Copy link
Contributor Author

catwell commented Jul 25, 2023

👋 Can someone please merge this before the next release?

I have updated the actual luafr page in case that helps to prove this is not malicious. If that isn't enough @hishamhm can shoot me an email to confirm. :)

Note: don't worry if there isn't a release of LuaRocks in the next few months, in that case I will renew the domain one more year to avoid problems.

Also FYI I used to pull from the Git repository but I just switched to directly crawling the manifests because of this issue.

@hishamhm hishamhm merged commit bb9d7ed into luarocks:master Jul 26, 2023
8 checks passed
@catwell catwell deleted the pr/loadk-mirror branch September 29, 2023 09:08
@catwell
Copy link
Contributor Author

catwell commented Sep 29, 2023

Given that there was no release, I have renewed the domain for one more year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants