Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence warning which only appears when rebuilding manifest #1591

Merged
merged 1 commit into from Feb 19, 2024

Conversation

hishamhm
Copy link
Member

Fixes #1446.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (4eee542) 79.07% compared to head (1f9561f) 84.72%.
Report is 3 commits behind head on master.

❗ Current head 1f9561f differs from pull request most recent head b32d306. Consider uploading reports for the commit b32d306 to get more accurate results

Files Patch % Lines
src/luarocks/cmd.lua 51.35% 18 Missing ⚠️
src/luarocks/core/cfg.lua 63.63% 4 Missing ⚠️
src/luarocks/util.lua 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
+ Coverage   79.07%   84.72%   +5.64%     
==========================================
  Files          89       94       +5     
  Lines       11218    11938     +720     
==========================================
+ Hits         8871    10114    +1243     
+ Misses       2347     1824     -523     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hishamhm hishamhm merged commit fe4cb07 into master Feb 19, 2024
10 checks passed
@hishamhm hishamhm deleted the fix-1446 branch February 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make-manifest spits out warnings "Couldn't load rockspec for ...." when rockspec has been deleted
2 participants