Remove Roblox-specific mutable globals #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this was on my list. This change would need to have a fast flag though because otherwise there's not going to be a safe way for us to deploy it, as it also requires associated changes in Roblox specific code. |
zeux
reviewed
Nov 8, 2021
zeux
reviewed
Nov 8, 2021
zeux
reviewed
Nov 8, 2021
|
@zeux Here you go, all tests passing (about to pass on CI too). Sorry for the bumpy ride. :) lmk if you'd like the LuauGenericSpecialGlobals=false and LuauGenericSpecialGlobals=true tests to be separated. |
zeux
reviewed
Nov 8, 2021
zeux
reviewed
Nov 8, 2021
zeux
approved these changes
Nov 8, 2021
|
Checks passed, ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kSpecialGlobalsis used by the compiler to disable the import optimization for values that are fetched from a mutable source (for example,_G.xd). Not only does this currently include Roblox-specific globals that might mean totally different things in other applications, but there's no way for embedding applications to specify if they have their own globals that act this way, which means that the import optimization may misbehave in those cases.In vanilla Luau, only the
_Gglobal is mutable. Roblox can use the newly-implementedmutableGlobalNamescompile option to specify its own globals - and crucially, third-party applications can as well.