Add support for ClassType indexer in definition files #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfriesen
reviewed
Jun 9, 2023
| @@ -1151,6 +1152,15 @@ ControlFlow ConstraintGraphBuilder::visit(const ScopePtr& scope, AstStatDeclareC | |||
|
|
|||
| scope->exportedTypeBindings[className] = TypeFun{{}, classTy}; | |||
|
|
|||
| if (FFlag::LuauParseDeclareClassIndexer && declaredClass->indexer) | |||
| { | |||
| // TODO: Recursion limit. | |||
There was a problem hiding this comment.
Take a look at ConstraintGraphBuilder::checkPack(const ScopePtr&, AstExpr*, const std::vector<std::optional<TypeId>>&) for an example of how to implement this.
There was a problem hiding this comment.
This was copied from the AstTypeTable code which has the same TODO comment, but yeah I can add it in
https://github.com/Roblox/luau/blob/3ecd3a82abe6682988112cd6eb7326a67ebbc47f/Analysis/src/ConstraintGraphBuilder.cpp#L2494-L2501
JohnnyMorganz
commented
Jun 9, 2023
Comment on lines
+1159
to
+1169
| if (recursionCount >= FInt::LuauCheckRecursionLimit) | ||
| { | ||
| reportCodeTooComplex(declaredClass->indexer->location); | ||
| } | ||
| else | ||
| { | ||
| ctv->indexer = TableIndexer{ | ||
| resolveType(scope, declaredClass->indexer->indexType, /* inTypeArguments */ false), | ||
| resolveType(scope, declaredClass->indexer->resultType, /* inTypeArguments */ false), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Its not completely similar to checkPack so i put it as an if-else instead of an early return. I assume we should continue processing the CTV even if the indexer is too complex
andyfriesen
approved these changes
Jun 12, 2023
andyfriesen
added a commit
that referenced
this pull request
Jun 16, 2023
* Definition files can now ascribe indexers to class types. (#949) * Remove --compile support from the REPL. You can just use luau-compile instead. * When an exception is thrown during parallel typechecking (usually an ICE), we now gracefully stop typechecking and drain active workers before rethrowing the exception. New solver * Include more source location information when we hit an internal compiler error * Improve the logic that simplifies intersections of tables JIT * Save testable type annotations to bytecode * Improve block placement for linearized blocks * Add support for lea reg, [rip+offset] for labels * Unify X64 and A64 codegen for RETURN * Outline interrupt handlers for X64 * Remove global rArgN in favor of build.abi * Change A64 INTERRUPT lowering to match X64 --------- Co-authored-by: Arseny Kapoulkine <arseny.kapoulkine@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
RomanKhafizianov
added a commit
to RomanKhafizianov/luau
that referenced
this pull request
Nov 27, 2023
* Definition files can now ascribe indexers to class types. (luau-lang/luau#949) * Remove --compile support from the REPL. You can just use luau-compile instead. * When an exception is thrown during parallel typechecking (usually an ICE), we now gracefully stop typechecking and drain active workers before rethrowing the exception. New solver * Include more source location information when we hit an internal compiler error * Improve the logic that simplifies intersections of tables JIT * Save testable type annotations to bytecode * Improve block placement for linearized blocks * Add support for lea reg, [rip+offset] for labels * Unify X64 and A64 codegen for RETURN * Outline interrupt handlers for X64 * Remove global rArgN in favor of build.abi * Change A64 INTERRUPT lowering to match X64 --------- Co-authored-by: Arseny Kapoulkine <arseny.kapoulkine@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.