-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init exception with latest Xamarin.Forms 3.4 / 3.6 #1154
Comments
Same issue here. |
+1 |
same issue |
Same here |
Did you try to delete all |
Deleted from those projects that uses these packages. No affect to me. I even restarted Vs17 but error remained. |
Could you write more info of your dev environment? Xamarin.Android version, VS version, etc? |
I was getting FATAL error using XF 3.4 on Xamarin.Forms App running on Android platform VS Community 15.9.1 |
Now back to XF v3.2 but not happy about that choice when I want to use FFImageloading while making use of XF 3.4 and next ones ... |
VS17 Enterprise 15.8.9, Works on Xamarin.Forms 3.3.0.967583 |
@daniel-luberda - with the new rhythm for Xamarin.Forms release since 3.2 .. It might be worthwhile to have regression plugged in to validate compatibility and report any issues into Xamarin.Forms team directly .. ? thoughts ? In the mean time, please help in updating FFImageLoading compatible with XF 3.3, 3.4 that will also help in picking up the images with resolution corresponding to the underlying device resolution. Thanks |
Could you try 2.4.4.858-pre.nupkg? |
did it pass your regression under XF 3.3 and 3.4; including image issue I mentioned above ? Sorry but thanks a lot. |
I only updated packages & recompiled as I can't reproduce that issue on my projects (even sample project from FFImageLoading is working fine). I'm on beta channel (Mac)
Could you explain it in details and create a separate issue for it? |
@daniel-luberda .. the FATAL error is gone but images problem I mentioned as in XF 3.3 still exist. |
Did you compile it against XF 3.4 or XF 3.3 ? |
3.4
I don't use Gorilla Player but I don't think it's FFImageLoading related issue. You can review code responsible for retrieving assets here: https://github.com/luberda-molinet/FFImageLoading/tree/master/source/FFImageLoading.Droid/DataResolvers and you'll see that it supports device size specific assets. |
Well.. I am just wondering how come that's working with XF 3.2 and stable version of FFImageloading ? |
@daniel-luberda |
@daniel-luberda - will you be releasing a stable version today ? |
Still seeing this issue in the release that just went out
FFImageLoading 2.4.4.859 Deleted all obj&bin and cleared nuget cache. |
Worth noting I'm seeing this in Forms 3.3.0 as well, it only occurs though after updating to VS 17.9, in 15.8 everything was okay. Have you tested with 17.9? |
@mackayn Hi, I tested it on Mac VS 7.7 but I don't see anything related to FFImageLoading in the given stack trace. Are you sure it's FFImageLoading? Maybe it's other lib? I didn't make any fix for XF 3.4 - I only rebuild it with XF packages updates. Maybe VS is caching those files somewhere? @IoTFier Stable is released already |
It's definitely FFImageLoading that fails |
I had the same TypeLoadException on Mac as well, until I upgraded the XF package from 3.4.0-pre1 to stable. As @daniel-luberda says it's probably the IDE holding onto something. In any case, 2.4.4 definitely works with XF 3.4.0 stable. |
@daniel-luberda, a BIG THANK for removing FATAL Error. Appreciate your help in making us look good. Many paid vendors struggle to reach this bar and level of understanding to serve their customers. A big Applaud for your professionalism. Thank you ! |
Yah, finally got there, delete all obj & bin, close VS, clear %temp%, re-open VS, clear nuget cache, open solution, restore & rebuild, all good. Thanks for sorting this so quickly. |
@daniel-luberda It seems that some images that were displayed correctly using the old version can't be displayed with the new one. |
@daniel-luberda I've installed the latest preview version (2.4.5.900-pre) and everything works fine. Thank you. |
I pushed quite a lot of fixes and improvements lately. New prerelease package should be a lot more performant, especially on Android. I tested it while fast scrolling tons of images (also with poor internet connection scenario), not a single crash or exception and memory usage is lower than with previous versions. SVG parsing is also improved, etc. I plan to release new stable. If you could test prerelease first and submit your feedback I would be grateful as I would like to fix all potential issues before a release. |
@daniel-luberda I upgraded to the latest prerelease package but SVG images that were displayed by the old version (2.3.6) can't be displayed. |
Also having this issue that IbrahimElshafey mentioned. Using the latest stable Xamarin Forms release.
|
|
SkiaSharp wasn't referenced in my project, so I guess it was whichever version is bundled with Xamarin? |
@daniel-luberda First of all thank you, I very appreciate your work, FFIL is an essential package to any Xamarin.Forms project. |
@IbrahimElshafey Thanks.
|
@daniel-luberda Thanks for your response.
If I deleted the fill attribute (
|
@daniel-luberda I didn't want to waste your time If it works fine on your machine ignore the latest message because I use the old version in the real project and it works fine. |
@daniel-luberda It may be some packages cached on my machine I will try again. |
Clear your Visual Studio nuget cache. |
@mackayn I tried this already, I deleted all FFIL packages in the packages folder |
Using 2.4.5.909-pre and Xamarin forms 3.6.0.344457 resolves this issue for me. |
Hi Using 2.4.5.909-pre (Core, iOS and Android) and Xamarin forms 3.6.0.344457 but the images are not visible. |
I confirm |
Same issue here, SVGs are not rendered |
Please make sure you:
|
…age to avoid runtime error luberda-molinet/FFImageLoading#1154
This worked, however, only the first time i run the app after a clean+delete obj/bin+rebuild. Is there a reason? |
I have install SkiaSharp and it's working. Thanks @daniel-luberda |
Is there a solution to this problem? |
commit your code or take a copy of your project. |
Using version 2.4.4.859 works well with XForms 3.4.0.1009.
|
Hello, It throws this exception:
I did everything requested here: https://github.com/luberda-molinet/FFImageLoading/wiki/Xamarin.Forms-API#step-1 I did not do:
As it is optional - I don't use SVG, and I don't use transformations |
@IoTFier screenshots helped me a lot.. thanks.... |
Description
I updated the Xamarin.Forms NuGet Package to the latest version and now I get an exception on OnCreate in Android (iOS untested so far).
Actual Behavior
Basic Information
Reproduction Link / Code
In MainActivity, in OnCreate(), it happens on this line:
FFImageLoading.Forms.Platform.CachedImageRenderer.Init(enableFastRenderer: true);
The text was updated successfully, but these errors were encountered: