Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement key map overrides for jogging. Prevent key shortcuts from disrupting typing in Text fields (e.g. Terminal Console) #285

Merged

Conversation

aaronse
Copy link

@aaronse aaronse commented Dec 30, 2022

See #284 and #283 for details

…isrupting typing in Text fields (e.g. Terminal Console)
@luc-github
Copy link
Owner

@aaronse I have implemented support for all keys for 3D Printer jog and created a new input text flag for capture shortkey, so I do not have to generate an array of all possible key mapping , doing that it was trivial to add combination keys support so I did it 😸

So I did not merged your PR yet

Do you want to update your PR to support combination keys? (you can refer to here to do the match )
then I will merge your PR
Or I merge your PR first, and I modify your code accordingly by myself

Please let me know

@aaronse
Copy link
Author

aaronse commented Dec 31, 2022

Nice! Look forward to trying out the changes, am in Seattle time zone so won't be trying until much later today.

Or I merge your PR first, and I modify your code accordingly by myself

Please merge and modify, seems like faster option. Cheers!

@luc-github luc-github merged commit 1094d87 into luc-github:3.0-keyboard-remaping Dec 31, 2022
@luc-github
Copy link
Owner

Modifications done - let me know what you think
If ok it can be ported to jogCNC / jogPlotter

@aaronse
Copy link
Author

aaronse commented Dec 31, 2022

Just read the changes, they look good to me. Will pull, build and try out later today. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants