Fix for issue #618 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a issue in the end-to-end workflow when starting from a Chandra observation file. The full instrument response functions where used, as opposed to the TOW ones, to compute the exposure ratio of the two instruments when generating the photon list, which resulted in the events being effectively filtered with the GPD quantum and trigger efficiency twice.
We have also changed the content of the RA and DEC columns of the photon list files to represent the sky coordinates pre-dithering, which is more in line with what is written in the documentation. Note that this change has no practical effect on the simulation output, as we only really feed photons in (dithered) detector coordinates to ixpesim.