-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Async version of .LoadJSON()? #261
Comments
Hi @scambier , that's a good idea. I would support an async version of Thank you for the good idea :) |
Here it is :) I did my best to dedupe the code, but the |
* Async loading * import types * #261 Dedupe and test .loadJSONAsync() * Added a missing comment
Thanks for the merge 🎉 |
Thank you for the contribution! I will soon publish a new release |
Hello :)
I'm using MiniSearch for my Obsidian plugin Omnisearch. It works wonderfully (thank you!), but for a certain category of users with literally thousands of documents, the
.LoadJSON()
function takes a long time - often more than 10 seconds! - during which the main thread is totally blocked.I experimented a bit and wrote an async version of this function. The load time is obviously a bit longer, but the user experience is, in my opinion, greatly improved.
Now I understand that supporting large indexes is a non-goal of MiniSearch, buuuuuuut.... 😁 what do you think?
The text was updated successfully, but these errors were encountered: