Async load json #262
Merged
Async load json #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks great! I will merge this tomorrow, as now it's late here and I want to give it one last look with fresh eyes. |
lucaong
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.loadJSONAsync()and.loadJSAsync()that are counterparts to their non-async version.loadJSONAsync()creates a MiniSearch instance that is identical to.loadJSON()importwithimport typebecause TypeScript wasn't happy when I imported the project as a local dependencyI tried to dedupe the code as much as possible. However, the several
awaitcalls in inner loops prevent to do this cleanly without reducing code readability.