hack for MAX31865 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with documentation and ability to pass in GPIO settings... |
lucapinello
previously requested changes
Mar 9, 2019
| # keep setting fan to recover from race condition. | ||
| time.sleep(2) | ||
| roast_control.set_fan_speed(9) | ||
| time.sleep(2) |
There was a problem hiding this comment.
very interesting, I noticed before something was not correct. This should fix it
There was a problem hiding this comment.
Yeah I further had to add a bit more delay to trigger the fan over the course of 10 seconds or so.
lucapinello
dismissed
their stale review
My fault the raise was to deprecate that method..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, somewhat not appropriate to be merged yet, but for your review.