Add previous model action (so if a lookup parser chooses action 89, you have it) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-breaking if possible.
…caues I needed it.
|
What's the difference between previous_action and previous_model_action? I see the reward fn is getting both |
|
Ah I see, it's the action before being parsed |
|
How are you using this value in your reward fn and obs builder? I'd like to understand the usecase a bit better |
|
In the rewards I punish switching actions to encourage sticking with one
submodel (this was your idea, lol). I think that may or may not have value
for a normal lookup parser model.
In the obs I normalize it (divide by number of lookup possibilities so it's
from 0 to 1) and then put it on an action stack. I can have a 30 stack of
previous actions (a full second at 4 tick skip) in only 30 obs spaces
instead of taking 240 spaces like normal. I think that part might have
value for a lookup parser.
…On Fri, Dec 23, 2022, 6:38 AM lucas-emery ***@***.***> wrote:
How are you using this value in your reward fn and obs builder? I'd like
to understand the usecase a bit better
—
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWLB4KV77PYCF4NDJUKPVPLWOWFLPANCNFSM6AAAAAASV4OOXE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea if this is valuable enough to anyone except me to be worth it. It's currently a breaking change, but perhaps someone smarter than me can take a look and see if it's possible to do it better, or just if it's worth making it breaking for rlgym 2.0 maybe.