-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
form markup in /settings breaks save #246
Comments
I'm confused. There are not two forms here. Only one. I see only one set of On Wed, Nov 7, 2012 at 3:47 PM, Lucas Gonze notifications@github.comwrote:
\/////MAKERLAB/////\ Jellyfish Gallery 971-227-4384m: paige@makerlab.com |
Not if you look in the markup. That's exactly the point. In the markup there is , but only one [save]button. On Wed, Nov 7, 2012 at 4:30 PM, Paige Saez notifications@github.com wrote:
|
Actually, don't worry about it. I can fix this. Reassigning to myself. |
In /settings, there are actually two forms, one for the top part and one for the bottom.
But from a functional and semantic perspective this breaks things. The user isn't expecting to submit the top with one button and the bottom with a different button. We could hack around this problem with javascript but this would be an excessively complex solution compared to just fixing the markup to reflect the reality that there should only be one form.
The text was updated successfully, but these errors were encountered: