Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've added a test case for LDEV-3091 #1061

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

cfmitrah
Copy link
Member

@cfmitrah cfmitrah commented Oct 9, 2020

No description provided.

}

private struct function getCredencials() {
// getting the credetials from the enviroment variables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// getting the credetials from the enviroment variables
// getting the credentials from the environment variables

mySQL.database=server.system.environment.MYSQL_DATABASE;

}
// getting the credetials from the system variables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// getting the credetials from the system variables
// getting the credentials from the system variables

</cfcatch>
</cftry>
</cfif>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

</cftry>
</cfif>

<cfif form.scene EQ 2 AND form.columnName NEQ "">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<cfif form.scene EQ 2 AND form.columnName NEQ "">
<cfif form.scene EQ 2 AND form.columnName NEQ "">

<cfparam name="FORM.columnName" default="">
<cfparam name="FORM.value" default="">

<cfif form.scene EQ 1 AND form.columnName NEQ "">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<cfif form.scene EQ 1 AND form.columnName NEQ "">
<cfif form.scene EQ 1 AND form.columnName NEQ "">

<cfif form.scene EQ 1 AND form.columnName NEQ "">
<cftry>
<cfquery name="insert" datasource="LDEV3091">
insert into ldev3091(#form.columnName#) values (<cfqueryparam value='#form.value#' >)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
insert into ldev3091(#form.columnName#) values (<cfqueryparam value='#form.value#' >)
insert into ldev3091(#form.columnName#) values (<cfqueryparam value='#form.value#'>)

@@ -0,0 +1,63 @@
component {

mySQL=getCredencials();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mySQL=getCredencials();
mySQL=getCredentials();

}
}

private struct function getCredencials() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private struct function getCredencials() {
private struct function getCredentials() {

@michaeloffner michaeloffner merged commit 5514bc2 into lucee:5.3 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants