Additional logging in scheduled tasks #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional logging was added to scheduled tasks while looking into problems detailed in this ticket: https://luceeserver.atlassian.net/browse/LDEV-897 I thought that it might be useful going forward.
|
Please merge this PR. It would have saved us days of frustration at my work if we had some way to see why tasks were silently failing while we were debugging them. |
|
Is there a reason you used DateTimeImpl instead of the CFML functions like DateFormat() and DateDiff()? |
|
I just tried to copy what was already there. DateTimeImpl was already being used in log output so assumed that was the right thing to use. My knowledge of Java is minimal. |
|
Is there anything else I need to do in order to get this accepted?? |
|
Sorry for the delay. I will try to look at this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional logging was added to scheduled tasks while looking into problems detailed in this ticket:
https://luceeserver.atlassian.net/browse/LDEV-897
I thought that it might be useful going forward.