Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDEV-3640 QoQ needs to preserve nulls internally regardless of full null support #1398

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

bdw429s
Copy link
Contributor

@bdw429s bdw429s commented Jul 27, 2021

@bdw429s
Copy link
Contributor Author

bdw429s commented Jul 27, 2021

I made a few subtle, but important changes here

  • stop detecting null support and returning strings internally. Just use nulls exclusively inside the query object-- they'll be converted later when the query is used if necessary
  • Make sure I pass in a default value of null any time I access the value of a cell to prevent the null-default of an empty string kicking in
  • Ensure all cell access is via QueryColumn.get(), which is the only way to get a a raw cell value and NOT have the nulls changed to empty strings.

@zspitzer zspitzer merged commit 3eda9eb into lucee:5.3 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants