Skip to content

Commit

Permalink
Remove aliasesSupport flag from rollup.config.mjs (#1794)
Browse files Browse the repository at this point in the history
* Remove aliasesSupport flag from rollup.config.mjs and add always add aliases

* Update rollup.config.mjs

* Update rollup.config.mjs

* Update rollup.config.mjs

* Update rollup.config.mjs

---------

Co-authored-by: Rigó József Karsa <karsa@sztaki.hu>
  • Loading branch information
karsa-mistmere and Rigó József Karsa committed Jan 16, 2024
1 parent be3ccc8 commit d4cbe89
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 69 deletions.
19 changes: 2 additions & 17 deletions packages/lucide-preact/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,34 +22,20 @@ const bundles = [
format: 'cjs',
inputs,
outputDir,
aliasesSupport: true
},
{
format: 'esm',
inputs,
outputDir,
preserveModules: true,
aliasesSupport: true
},
];

const configs = bundles
.map(({ inputs, outputDir, format, minify, preserveModules, aliasesSupport }) =>
.map(({ inputs, outputDir, format, minify, preserveModules }) =>
inputs.map(input => ({
input,
plugins: [
...(
!aliasesSupport ? [
replace({
"export * from './aliases';": '',
"export * as icons from './icons';": '',
delimiters: ['', ''],
preventAssignment: false,
}),
] : []
),
...plugins(pkg, minify)
],
plugins: plugins(pkg, minify),
external: ['preact'],
output: {
name: packageName,
Expand Down Expand Up @@ -81,4 +67,3 @@ const configs = bundles
},
...configs
];

19 changes: 2 additions & 17 deletions packages/lucide-react/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const bundles = [
format: 'cjs',
inputs,
outputDir,
aliasesSupport: true,
},
{
format: 'esm',
Expand All @@ -35,13 +34,11 @@ const bundles = [
],
outputDir,
preserveModules: true,
aliasesSupport: true,
},
{
format: 'esm',
inputs: ['src/dynamicIconImports.ts'],
outputFile: 'dynamicIconImports.js',
aliasesSupport: true,
external: [/src/],
paths: (id) => {
if (id.match(/src/)) {
Expand All @@ -54,22 +51,10 @@ const bundles = [
];

const configs = bundles
.map(({ inputs, outputDir, outputFile, format, minify, preserveModules, aliasesSupport, entryFileNames, external = [], paths }) =>
.map(({ inputs, outputDir, outputFile, format, minify, preserveModules, entryFileNames, external = [], paths }) =>
inputs.map(input => ({
input,
plugins: [
...(
!aliasesSupport ? [
replace({
"export * from './aliases';": '',
"export * as icons from './icons';": '',
delimiters: ['', ''],
preventAssignment: false,
}),
] : []
),
...plugins(pkg, minify)
],
plugins: plugins(pkg, minify),
external: [
'react',
'prop-types',
Expand Down
20 changes: 2 additions & 18 deletions packages/lucide-vue-next/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,35 +22,20 @@ const bundles = [
format: 'cjs',
inputs,
outputDir,
aliasesSupport: true
},
{
format: 'esm',
inputs,
outputDir,
preserveModules: true,
aliasesSupport: true
},
];

const configs = bundles
.map(({ inputs, outputDir, format, minify, preserveModules, aliasesSupport }) =>
.map(({ inputs, outputDir, format, minify, preserveModules }) =>
inputs.map(input => ({
input,
plugins: [
// This for aliases, only for esm
...(
!aliasesSupport ? [
replace({
"export * from './aliases';": '',
"export * as icons from './icons';": '',
delimiters: ['', ''],
preventAssignment: false,
}),
] : []
),
...plugins(pkg, minify)
],
plugins: plugins(pkg, minify),
external: ['vue'],
output: {
name: packageName,
Expand Down Expand Up @@ -88,4 +73,3 @@ const configs = bundles
},
...configs
];

19 changes: 2 additions & 17 deletions packages/lucide-vue/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -21,35 +21,20 @@ const bundles = [
format: 'cjs',
inputs,
outputDir,
aliasesSupport: true
},
{
format: 'esm',
inputs,
outputDir,
preserveModules: true,
aliasesSupport: true
},
];

const configs = bundles
.map(({ inputs, outputDir, format, minify, preserveModules, aliasesSupport }) =>
.map(({ inputs, outputDir, format, minify, preserveModules }) =>
inputs.map(input => ({
input,
plugins: [
// This for aliases, only for esm
...(
!aliasesSupport ? [
replace({
"export * from './aliases';": '',
"export * as icons from './icons';": '',
delimiters: ['', ''],
preventAssignment: false,
}),
] : []
),
...plugins(pkg, minify)
],
plugins: plugins(pkg, minify),
external: ['vue'],
output: {
name: packageName,
Expand Down

0 comments on commit d4cbe89

Please sign in to comment.