Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unlink icons #10

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Conversation

ericfennis
Copy link
Member

@ericfennis ericfennis commented Jun 16, 2020

Closes #26

Old comment from the thread

image

For the unlink for the link variant I tried to keep the lines of the link icon.
So this is the link with overlayed over the original link icon.
image

I followed the Icon guide lines from #171. But it's hard with this one to keep the original lines of the link icon and keep exactly 2 pixels of spacing.

@johnletey
Copy link
Collaborator

🤔 I'm not too sure about the unlink-2 icon.

What do you think about this for the unlink icon:

unlink

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M18.84 12.25L20.56 10.54H20.54C21.4606 9.58604 21.9651 8.30573 21.9426 6.98018C21.9201 5.65462 21.3725 4.39217 20.42 3.47C19.4869 2.57019 18.2412 2.06739 16.945 2.06739C15.6488 2.06739 14.4031 2.57019 13.47 3.47L11.75 5.18" />
  <path d="M5.17 11.75L3.46 13.46C2.53937 14.414 2.03492 15.6943 2.05742 17.0198C2.07992 18.3454 2.62752 19.6078 3.58 20.53C4.51305 21.4298 5.75876 21.9326 7.055 21.9326C8.35124 21.9326 9.59695 21.4298 10.53 20.53L12.24 18.82" />
  <path d="M8 2V5" />
  <path d="M2 8H5" />
  <path d="M16 19V22" />
  <path d="M19 16H22" />
  <path d="M19 19L21 21" />
  <path d="M3 3L5 5" />
</svg>

@johnletey johnletey changed the title add unlink icons feat: Add unlink icons Jun 17, 2020
@locness3
Copy link
Contributor

What do you think about this for the unlink icon:

I personally prefer ericfennis's version, because it has less "pops"

@ericfennis
Copy link
Member Author

I tried the unlink icon also with three strokes but It looked a bit messy to me.

here both side by side for comparison

image
image

image

@ericfennis
Copy link
Member Author

A suggestion from @jletey to create a link-2-off icon as well. (Discussed in the discord channel)
I like the idea, I think it's nice to have them both, both are nice for using.

image

use cases

  • The unlink variant is I think nice if you have list of items and you want to use a subtle unlink icon.
  • And the link-2-off is more a "active/direct/more awaring" way of unlinking, maybe less nice to use in a list, but nicer if you "Disconnect" something.

conclusion So I think we need to implement both.

Copy link
Collaborator

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericfennis These are 🔥🔥🔥 Could you maybe add a newline at the EOF to link-2 and unlink-2?

@ericfennis
Copy link
Member Author

Good one, I will add some.

Copy link
Collaborator

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericfennis Thanks for that, LGTM 🚀

Just a thought, is it just me or does link-2-off seem too long 😅

@locness3 Any thoughts?

Copy link
Contributor

@locness3 locness3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnletey johnletey merged commit 90966d2 into lucide-icons:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: unlink
3 participants