Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add book-* (git repository) icons #1011

Merged
merged 10 commits into from
Apr 12, 2023
Merged

Add book-* (git repository) icons #1011

merged 10 commits into from
Apr 12, 2023

Conversation

danielbayley
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

Added or changed icons

icons/book-copy.svg icons/book-down.svg icons/book-key.svg icons/book-lock.svg icons/book-marked.svg icons/book-minus.svg icons/book-plus.svg icons/book-template.svg icons/book-up.svg icons/book-x.svg

@karsa-mistmere
Copy link
Member

The bookmark still violates the guidelines I'm afraid, maybe something like this could work:

  <path d="M16 16v6l-2-1.5-2 1.5v-6" />

image

Not sure about the names in general and the need for the bookmark though, I'd prefer keeping book as it is, adding the repository tag, removing the bookmarks and naming everything along the lines of book-plus, book-minus, book-key, book-arrow-down etc.

@danielbayley
Copy link
Member Author

the need for the bookmark

I think the bookmark is the only thing to identify it as a repo, like Octicons. I’m cool with naming them book-up etc though…

I'd prefer keeping book as it is

The book icon itself is unchanged.

@danielbayley danielbayley changed the title Add git repository icons Add book-* (git repository) icons Apr 4, 2023
@danielbayley danielbayley force-pushed the git-repos branch 2 times, most recently from d364347 to 6213a49 Compare April 4, 2023 14:36
karsa-mistmere
karsa-mistmere requested changes Apr 5, 2023
View reviewed changes
icons/book-copy.svg Outdated Show resolved Hide resolved
icons/book-down.svg Outdated Show resolved Hide resolved
icons/book-down-2.svg Outdated Show resolved Hide resolved
icons/book-key.svg Outdated Show resolved Hide resolved
icons/book-lock.svg Outdated Show resolved Hide resolved
icons/book-marked.svg Outdated Show resolved Hide resolved
@karsa-mistmere
Copy link
Member

book-copy doesn't have the necessary 1px padding, other than that LGTM.

@danielbayley
Copy link
Member Author

book-copy doesn't have the necessary 1px padding, other than that LGTM.

It was misaligned. Fixed now…

karsa-mistmere
karsa-mistmere approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@karsa-mistmere karsa-mistmere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @danielbayley, I think this is good to go if @ericfennis also approves. :)

ericfennis
ericfennis approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbayley Whoa those look really awesome! 🔥
Thanks for all your contributions, you do a great job!

@ericfennis ericfennis merged commit ded24ab into lucide-icons:main Apr 12, 2023
@danielbayley danielbayley deleted the git-repos branch April 12, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

@karsa-mistmere karsa-mistmere karsa-mistmere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbayley @karsa-mistmere @ericfennis