-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed overlapping line in align-horizontal-distribute-end
#1608
Conversation
@@ -9,8 +9,8 @@ | |||
stroke-linecap="round" | |||
stroke-linejoin="round" | |||
> | |||
<rect width="6" height="14" x="4" y="5" rx="2" /> | |||
<rect width="6" height="10" x="14" y="7" rx="2" /> | |||
<path d="M10 17a2 2 0 0 1-2 2H6a2 2 0 0 1-2-2V7a2 2 0 0 1 2-2h2a2 2 0 0 1 2 2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we go for more code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes two places where elements are on top of each other, it's imo okay to have that.
Just wanted to know what everyone else is thinking about overlapping lines like we have here.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
@jguddas Overlapping is currently happening with a lot of icons right now. I agree there is an improvement to be made to support opacity colors like The idea of merging paths is something we need to research, I prefer to do this on built time. this is added to the list on Lucide v1, see issue #1687. I'm not in favor of fixing this individually, so I close this one for now |
What is the purpose of this pull request?
Let me ask, should we have overlapping lines like we have in icons like this?