Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-twitter icon #1717

Closed
wants to merge 1 commit into from
Closed

Add x-twitter icon #1717

wants to merge 1 commit into from

Conversation

JamesReich
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adding the new X logo to the socials, twitter is currently available but we're missing X, this PR looks to add that.

Icon use case

Matching socials with other icons in the library, linking to your X @handle with lucide style icon.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

https://about.twitter.com/en/who-we-are/brand-toolkit

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Dec 9, 2023
Copy link

github-actions bot commented Dec 9, 2023

Added or changed icons

icons/x-twitter.svg

Preview cohesion icons/mouse-pointer-square.svg
icons/x-twitter.svg
icons/arrow-big-down-dash.svg
Preview stroke widths icons/x-twitter.svg
icons/x-twitter.svg
icons/x-twitter.svg
DPI Preview (24px) icons/x-twitter.svg
Icon X-rays icons/x-twitter.svg

@karsa-mistmere
Copy link
Member

This is a brand icon, see #670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants