Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds various food icons #680

Merged
merged 13 commits into from
Jul 11, 2022
Merged

Conversation

karsa-mistmere
Copy link
Member

closes #678

Icon Request

  • Icon name:
  • Use case:
  • Screenshots of similar icons:

As per #119 and feathericons/feather#32 this PR adds further food icons.

image
food

@ericfennis
Copy link
Member

I appreciate the work, but I'm not sure about the amount of food icons.
Some are I think a bit too specific.
How do you think of this @locness3 ?

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented May 24, 2022

Yeah, I see where you're coming from.

Here are some use cases I could think of:

  • ice-cream: ice cream shop / gelateria location pin (not sure what feat: add ice-cream icon #678's proposed use case was, as @wojtekmaj didn't provide the icon request template)
  • apple/cherry/banana/grape: just representing fruit in general (these are all pretty iconic looking fruits I think), fruit and vegetable store, farmer's market, grocery store
  • grape is also usable for vineyards, wineries and wine places.
  • egg-fried: representing breakfast, or breakfast places.
  • pizza: pizzeria location pin / pizza as a food item for filtering.

The weak links are definitely popsicle (very specific), watermelon (looks a bit funky to begin with), and the citruses (lemon looks fine but does not maybe have too many varied use cases; orange looks a bit weak and is also weak regarding use cases).

@wojtekmaj
Copy link
Contributor

wojtekmaj commented May 24, 2022

Just to give come context around ice cream icon: we want to use it as an icon for Flavors subpage in an app for an ice cream venue :)

@ericfennis
Copy link
Member

@karsa-mistmere Thanks for the explanation.
I think one ice cream is ok.
For the others: I think grape and one or two fruit icons are enough. I understand that it maybe helpful for grocery store but then you should also add all the other "fruits" and "veggies", I think that is a bit to much. We should keep the icons we add a bit "general".
For breakfast I think I never saw a fried egg used. Maybe "utencils" or "coffee" should fit better.
I think one pizza icon is fine.

Let me know if you agree with this or not.

@karsa-mistmere
Copy link
Member Author

As for breakfast, these are from Foursquare & Swarm: CCE0F7F8-3D64-4F85-BC7B-224FB4906183
7B6D27B8-6863-4FFF-B44A-38CB540AA599
4B1FCBFA-2414-45A4-A71D-451B7E2F1FA4

I think we're basically in agreement about the rest.

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented May 30, 2022

I guess adding a slice of bacon to further clarify breakfast is also an option:
image
image

@ericfennis ericfennis merged commit 942b263 into lucide-icons:main Jul 11, 2022
@locness3
Copy link
Contributor

Sorry for not replying, I honestly do not have much interest in this project anymore.

I'd say these are too specific, but I'll trust you all with maintaining the quality and consistency of the whole icon set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants