Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator/Discriminator dim Argument #26

Closed
CerebralSeed opened this issue Jul 19, 2023 · 2 comments
Closed

Generator/Discriminator dim Argument #26

CerebralSeed opened this issue Jul 19, 2023 · 2 comments

Comments

@CerebralSeed
Copy link
Contributor

It seems that the current implementation of the Generator/Discriminator do not make any use of the primary dim argument. Looks like capacity is the main "go to" for altering the overall model size on the z dimension.

Perhaps dim could be removed, or the term capacity could be replaced with dim.
lucidrains added a commit that referenced this issue Jul 19, 2023
@lucidrains
address #26
857c12f
@lucidrains
Copy link
Owner

@CerebralSeed oh yes, decided to rename this dim_capacity 😆

@lucidrains
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucidrains @CerebralSeed