BREAKING CHANGE: Convert mail from flat-file to MySQL #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mail now runs out of MySQL database in the pfiles_mail table. This resolves #93 and should significantly improve the mailing experience. - Mail from shops will now identify the shopkeeper. - Mail will tell you the IRL timestamp it was sent on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit revamps the mail system from the buggy flat-file / strictly-sized system to an open-ended MySQL system. It clears out the #93 crashbug and enhances the mailing experience. However, it is a BREAKING CHANGE since you must add the mail SQL to your database.
To do so, execute the statement found in
SQL/mail_fixes.sqlin your database. This statement will be automatically executed for new databases.