Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 formatting #59

Closed
wants to merge 1 commit into from
Closed

Conversation

rockneurotiko
Copy link

I have autopep8 enabled and when I was reading the code to see if I can add/modify something I saw that the code wasn't really following the PEP 8 at all...

So here are the PR with the PEP 8 formatting, wich I recommend you to follow :) link to PEP 8

@luckydonald
Copy link
Owner

The tabs instead of 4 spaces are intended, as they are easier to work with (pressing delete 4 times instead of once is annoying).

Also the command table in [pytg/sender.py] would becomes completely unreadable.

So that won't happen, sorry.

Regarding the minor stuff like 2 spaces before comments etc., that will happen as soon as I edit something near there. My IDE is set up to highlight them. When I come around I do fix such stuff.

@rockneurotiko
Copy link
Author

You should configure your editor or use a better one, I only need one delete keystroke to remove all the spaces (all, you need "x" tabs keystroke). Also, you can do (with spaces or tabs) "select to beginning" and then remove, depending of your editor is one way or another, but Shift+Ctrl+A or Ctrl+A usually works.

I don't see it unreadable, and also it's not a file that you will need to change many times. With your spaces you need to manually sync them, and are error prone example

I undestand that you don't want to mix it, but follow the language standard is important, I'm improving and fixing some things, so, if this won't happen I'll keep doing it in my fork, you can check it if you want.

Besides the non pep8, it's a really great project 😄

@luckydonald
Copy link
Owner

Regarding the tabs, at least PyCharm detects usage of tabs, and can automatically use the same style as the edited document.

I'll apply

Tabs should be used [...] with code that is already indented with tabs.

here 😅

But I will have another look at this later.

luckydonald added a commit that referenced this pull request Feb 24, 2016
Addresses #59.
Spaces instead of tabs.

...
I still feel tabs being superior.
luckydonald added a commit that referenced this pull request Feb 24, 2016
Addresses #59.
Spaces instead of tabs.

...
I still feel tabs being superior.
@luckydonald
Copy link
Owner

@rockneurotiko
Yeah, you won :/

luckydonald added a commit to luckydonald/luckydonald-utils that referenced this pull request Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants