overwrite to_s and to_i for Enums #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making it possible to get int and the string directly, good for showing the enum on pages and such. Not it will return class instance on `to_s` and not work at all on `to_i`
jwoertink
reviewed
Oct 5, 2020
There was a problem hiding this comment.
We do use some delegation in Lucky as well https://github.com/luckyframework/lucky/search?q=delegate so I'd be ok with that. Also, right below this is the forward_missing_to @enum. Does that not already forward to_s and to_i? Or is it because all objects kind of respond to to_s that it's not really forwarded?
|
@jwoertink as I moved it to delegate now. |
jwoertink
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making it possible to get int and the string directly, good for showing the enum on pages and such.
Not it will return class instance on
to_sand not work at all onto_inow it will return say
Ongoingon to_s and0on to_inot sure if maybe this will work instead:
I feel it is a personal taste that feels best. I can change to that if you want.