Can preload has_one associations with existing records #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcgarvey
force-pushed
the
has-one-existing-record
branch
from
f7bf974
to
1029442
Compare
jwoertink
reviewed
Dec 3, 2020
There was a problem hiding this comment.
This looks good. One thing I just thought of, I don't see any specs to check that you can skip the preloads using the bang method (or am I just missing them?)
admin = AdminBox.create
sign_in_credential = SignInCredentialBox.create &.user_id(admin.id)
admin.sign_in_credential!.should eq sign_in_credential
|
@jwoertink I found a whole file file of specs for that feature https://github.com/luckyframework/avram/blob/master/spec/lazy_loading_spec.cr |
|
Oh good! 😅 These specs are all over the place lol. That works for me then. |
jwoertink
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #531