Require at least one column defined on models #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcgarvey
commented
Jul 12, 2021
src/avram/model.cr
Outdated
| @@ -72,6 +73,7 @@ abstract class Avram::Model | |||
| macro view(view_name = nil) | |||
| {{ yield }} | |||
|
|
|||
| validate_columns | |||
There was a problem hiding this comment.
I considered moving this macro into the setup list below but if I did that it would have added a layer to the error message that pointed at macro code so I thought this makes the error easier to understand
jwoertink
reviewed
Jul 12, 2021
src/avram/model.cr
Outdated
| @@ -147,6 +149,12 @@ abstract class Avram::Model | |||
| ) | |||
| end | |||
|
|
|||
| macro validate_columns | |||
| {% if COLUMNS.empty? %} | |||
| {% raise "#{@type} must define at least one column." %} | |||
There was a problem hiding this comment.
Can we add the typical Try this... example here too? Like column my_column : String would be fine I think.
There was a problem hiding this comment.
Updated it to match the validate_primary_key error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699