Custom setting for Time format #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Decided I'm going to close this. I'll open a separate PR with a different update |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #727
This PR allows you to set a custom format that will be used on all
Timecolumns. As of right now, we have no way to do this on a per-column level. It's all or nothing.I'm opening this as a draft because I'm still not sold on going this route. The fear is this gives people the wide open ability to just do
default_time_format = "%Y"which would set allcreated_at, andupdated_atto just the year, and would break all html forms using time inputs. Maybe we could just have ainclude_milliseconds = true? I'm not sure, but I'll keep thinking about it.