Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server port not changing despite change in config/watch.yml #570

Closed
edwardloveall opened this issue Aug 11, 2018 · 1 comment · Fixed by #1051
Closed

Server port not changing despite change in config/watch.yml #570

edwardloveall opened this issue Aug 11, 2018 · 1 comment · Fixed by #1051
Labels
bug

Comments

@edwardloveall
Copy link
Member

edwardloveall commented Aug 11, 2018 •
edited

When I try to change my config/watch.yml to a different port, BrowserSync still proxy's to port 5000. It also ignores when I set a port for the environment like so:

PORT=4567 lucky dev
# or
export PORT=4567
lucky dev
yarn run v1.9.4
$ path/to/app/node_modules/.bin/browser-sync start -c bs-config.js --port 3001 -p http://0.0.0.0:5000
web    | [Browsersync] Proxying: http://0.0.0.0:5000
@jwoertink jwoertink added the bug label Jun 4, 2019
@jwoertink
Copy link
Member

Just adding on to this:
Screen Shot 2019-09-05 at 8 54 01 AM

My .env has PORT=5000, but my config/watch.yml has port: 9090.

Also related: luckyframework/lucky_cli#324. TL;DR: the process runners will inject their own PORT env var which overrides this.

jwoertink added a commit that referenced this issue Mar 14, 2020
@jwoertink
Change development ENV from PORT to DEV_PORT so local running process…
cb20662 
… managers don't override what we use. Fixes #570
@jwoertink jwoertink mentioned this issue Mar 14, 2020
Merged
5 tasks
jwoertink added a commit that referenced this issue Mar 14, 2020
@jwoertink
Change development ENV from PORT to DEV_PORT so local running process…
e677da9 
… managers don't override what we use. Fixes #570 (#1051)
djuber pushed a commit to djuber/lucky that referenced this issue Aug 29, 2021
@ZimbiX @jwoertink
lucky dev: When Ctrl+C is pressed, wait for the child process to hand…
1085771 
…le the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background (luckyframework#572)

* lucky dev: When Ctrl+C is pressed, wait for the child process to handle the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background

Resolves luckyframework#570. I've just used the approach I suggested there.

I wasn't sure how/if to write a spec for this, so I haven't. Is that acceptable?

To test it manually, I ran this from my app directory before and after the change to verify the behaviour:

```bash
$ crystal run ~/Projects/lucky_cli/src/lucky.cr -- dev
```

* Update src/lucky_cli/process_runner.cr

* oops. formatted

Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change development ENV from PORT to DEV_PORT luckyframework/lucky
2 participants
@jwoertink @edwardloveall