Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic examples and design goals to README #572

Closed
paulcsmith opened this issue Aug 15, 2018 · 0 comments
Closed

Add basic examples and design goals to README #572

paulcsmith opened this issue Aug 15, 2018 · 0 comments

Comments

@paulcsmith
Copy link
Member

No description provided.

paulcsmith added a commit that referenced this issue Aug 23, 2018
paulcsmith added a commit that referenced this issue Aug 23, 2018
paulcsmith added a commit that referenced this issue Aug 23, 2018
paulcsmith added a commit that referenced this issue Aug 23, 2018
paulcsmith added a commit that referenced this issue Aug 23, 2018
paulcsmith added a commit that referenced this issue Aug 23, 2018
paulcsmith added a commit that referenced this issue Aug 23, 2018
djuber pushed a commit to djuber/lucky that referenced this issue Aug 29, 2021
…le the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background (luckyframework#572)

* lucky dev: When Ctrl+C is pressed, wait for the child process to handle the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background

Resolves luckyframework#570. I've just used the approach I suggested there.

I wasn't sure how/if to write a spec for this, so I haven't. Is that acceptable?

To test it manually, I ran this from my app directory before and after the change to verify the behaviour:

```bash
$ crystal run ~/Projects/lucky_cli/src/lucky.cr -- dev
```

* Update src/lucky_cli/process_runner.cr

* oops. formatted

Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant