Crystal 1.0 support #1445
Merged
Crystal 1.0 support #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… master branch to start testing for next release
jwoertink
commented
Mar 28, 2021
| @@ -117,7 +126,7 @@ describe Lucky::CookieJar do | |||
| it "raises an error if the cookie is > 4096 bytes" do | |||
| expect_raises(Lucky::CookieOverflowError) do | |||
| jar = Lucky::CookieJar.empty_jar | |||
| jar.set_raw(:overflow, "x" * (4097 - 27)) # "overflow=x...x; path=/; HttpOnly", | |||
| jar.set_raw(:overflow, "x" * 4097) # "overflow=x...x; HttpOnly", | |||
There was a problem hiding this comment.
I'm not sure why there was maths here, but it wasn't throwing an exception, so I just made it the raw number because "x" * 4097 is 4097 bytes
jwoertink
commented
Mar 28, 2021
| @@ -1,6 +1,6 @@ | |||
| class Lucky::CookieJar | |||
| MAX_COOKIE_SIZE = 4096 | |||
| LUCKY_ENCRYPTION_PREFIX = Base64.encode("lucky") + "--" | |||
| LUCKY_ENCRYPTION_PREFIX = Base64.strict_encode("lucky") + "--" | |||
There was a problem hiding this comment.
Base64.encode adds a newline at the end, but newline characters are invalid cookie values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update for Crystal 1.0 support
Description
The only main issue to support Crystal 1.0 is that cookie values are now more strict according to rfc6265. Crystal will raise
IO::Errorwhen setting a cookie value that contains invalid characters, so I added a nicer error that tells you which cookie is getting the error, and which characters to be on the look for.NOTE:
This PR points all shards to master branch, but it's sort of 🐔 🥚 while everything gets updated.