Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow to specify output directory for init via command line option #339

Closed
nicbet opened this issue May 15, 2019 · 2 comments · Fixed by #464
Closed

[Feature] Allow to specify output directory for init via command line option #339

nicbet opened this issue May 15, 2019 · 2 comments · Fixed by #464
Assignees
@paulcsmith
Labels
enhancement

Comments

@nicbet
Copy link

nicbet commented May 15, 2019

The command lucky init [name] creates a new new project in ./[name]. (Same holds when executing the wizard).

Perhaps there is a chance to expand the command line arguments the cli tool takes to be able to specify a differently named output directory, which would override @project_dir = project_name in the generator?

As a special corner case, I would like to be able to use the current directory as the target.
@paulcsmith
Copy link
Member

@nicbet Thanks for opening this issue! Just to figure out how to prioritize this, could you explain how this impacts your workflow? Is this a must have or is it fairly low impact?

@nicbet
Copy link
Author

nicbet commented Jun 6, 2019

@paulcsmith it would be more of a nice to have: would eliminate a copy step (see Readme https://github.com/nicbet/docker-lucky) and make the workflow more similar to other frameworks (e.g., see https://github.com/nicbet/docker-phoenix)

@paulcsmith paulcsmith self-assigned this Sep 26, 2019
jwoertink added a commit that referenced this issue Mar 14, 2020
@jwoertink
adding in custom directory support for custom.init generator. Fixes #339
6aabc8b
@jwoertink jwoertink mentioned this issue Mar 14, 2020
Merged
jwoertink added a commit that referenced this issue Mar 14, 2020
@jwoertink
Adding ability to set custom directory when using custom.init (#464)
2e8c1ff 
* ran formatter

* adding in custom directory support for custom.init generator. Fixes #339

* a few more spec updates to remove duplicate options being passed in to custom.init. Adding another example to the OptionParser output to make it clear that the arguments are optional
paulcsmith pushed a commit that referenced this issue Apr 7, 2020
@jwoertink @paulcsmith
Adding ability to set custom directory when using custom.init (#464)
be3b5cb 
* ran formatter

* adding in custom directory support for custom.init generator. Fixes #339

* a few more spec updates to remove duplicate options being passed in to custom.init. Adding another example to the OptionParser output to make it clear that the arguments are optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcsmith paulcsmith

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding ability to set custom directory when using custom.init luckyframework/lucky_cli
2 participants
@paulcsmith @nicbet