Adding ability to set custom directory when using custom.init #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Mar 14, 2020
| @@ -38,6 +38,7 @@ require "../spec_helper" | |||
| private def generate_heroku_app_name | |||
| app_name_base + "-" + Random::Secure.hex(4) | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
the crystal formatter did this
jwoertink
commented
Mar 14, 2020
| @@ -9,7 +9,7 @@ end | |||
| describe "Initializing a new web project" do | |||
| it "creates a full web app successfully" do | |||
| puts "Web app: Running integration spec. This might take awhile...".colorize(:yellow) | |||
| should_run_successfully "crystal run src/lucky.cr -- init.custom test-project test-project" | |||
There was a problem hiding this comment.
no clue why we had this doubled on all these specs lol
jwoertink
commented
Mar 14, 2020
| @@ -13,14 +13,18 @@ class LuckyCli::CustomInit < LuckyCli::Init | |||
| private def generate_project(project_name) | |||
| api_only = false | |||
| authentication = true | |||
| project_directory = "." | |||
There was a problem hiding this comment.
Just default it to the current directory you're in like it does now
jwoertink
commented
Mar 14, 2020
| ) | ||
| Dir.cd(File.expand_path(project_directory)) |
There was a problem hiding this comment.
The expand_path allows us to pass things like "." or ~/Projects and have it expand properly. We just cd in to the directory we want the project, then run everything as normal.
paulcsmith
approved these changes
Mar 14, 2020
| @@ -9,7 +9,7 @@ end | |||
| describe "Initializing a new web project" do | |||
| it "creates a full web app successfully" do | |||
| puts "Web app: Running integration spec. This might take awhile...".colorize(:yellow) | |||
| should_run_successfully "crystal run src/lucky.cr -- init.custom test-project test-project" | |||
…o custom.init. Adding another example to the OptionParser output to make it clear that the arguments are optional
paulcsmith
pushed a commit
that referenced
this pull request
Apr 7, 2020
* ran formatter * adding in custom directory support for custom.init generator. Fixes #339 * a few more spec updates to remove duplicate options being passed in to custom.init. Adding another example to the OptionParser output to make it clear that the arguments are optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
Right now we have a
custom.initgenerator that I don't think is used much. It only does the same as the wizard, but all through the command line. Now we can start to allow for some really custom options like setting a custom directory!This PR adds a new
--dir DIRflag to set the directory of where to generate your application. All it really does is cd in to that custom directory, and then generate the app as normal from that directory. This may be helpful for people using docker, or automating a build on to a server.