Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename procfile target #601

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

robacarp
Copy link
Contributor

@robacarp robacarp commented Feb 1, 2021

This is a compliment to luckyframework/heroku-buildpack-crystal#11

See luckyframework/heroku-buildpack-crystal#11 (comment)

I also added a target stanza to the shard.yml. It's an out of context update and I'm happy to pull the commit if needed.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I've ever seen the deploy to heroku specs run or not.. Will be interesting to see if they run and pass. I think just a little spec to ensure that's good, and we can merge this in.

src/web_app_skeleton/Procfile.ecr Show resolved Hide resolved
@@ -4,6 +4,10 @@ version: 0.25.0
authors:
- Paul Smith <paulcsmith0218@gmail.com>

targets:
lucky:
main: src/lucky.cr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll with it!

@jwoertink jwoertink merged commit 1b2673c into luckyframework:master Feb 4, 2021
@robacarp robacarp deleted the rename_procfile_target branch February 5, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants