Using html_with_status on the error page #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to not conflict with the named_arg in that marco. Fixes #678
|
requires luckyframework/lucky#1581 |
| @@ -80,7 +80,7 @@ class Errors::Show < Lucky::ErrorAction | |||
|
|
|||
| private def error_html(message : String, status : Int) | |||
| context.response.status_code = status | |||
There was a problem hiding this comment.
This line could be removed, right?
There was a problem hiding this comment.
No, it's used on the exception page https://github.com/crystal-loot/exception_page/blob/aa641f3905b4f4be68c8f569d16f793fc1338873/src/exception_page.cr#L75 😒
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
Technically fixes luckyframework/lucky#1575 too, though, I'm not sure if there's anything we can do about that conflicting with other people later...