Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer #19

Closed
paulcsmith opened this issue May 16, 2019 · 12 comments

Comments

@paulcsmith
Copy link
Member

commented May 16, 2019

No description provided.

@paulcsmith paulcsmith added this to the Ready to launch milestone May 16, 2019

@paulcsmith paulcsmith self-assigned this May 28, 2019

@jwoertink

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Some things the footer had previously:

  • Github link (icon)
  • Twitter link (icon)
  • Gitter link (icon)
  • Link to Code of Conduct
  • Link and mention of contributors
@robertguss

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

I can try and tackle this PR if you would like, I am a front-end dev. A couple of questions though:

  • Where can I find the links to the Code of Conduct and contributors?
  • by adding a twitter link & icon will that resolve issue #28? if not, let me know where you would like an additional Twitter link.
@paulcsmith

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Hey @robertguss! This would be wonderful.

And yes I think that'd resolve #28. I may want to add it somewhere else too but the footer is a great start.

@robertguss

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

@paulcsmith having an issue when I run up:

Error in src/start_server.cr:1: while requiring "./app"
app_1     |
app_1     | require "./app"
app_1     | ^
app_1     |
app_1     | in src/app.cr:27: while requiring "../config/**"
app_1     |
app_1     | require "../config/**"
app_1     | ^
app_1     |
app_1     | in config/database.cr:3: Avram::Repo has been renamed to Avram::Database and requires a subclass now.
app_1     |
app_1     | Try this...
app_1     |
app_1     |   1. Create a database class called 'AppDatabase' that inherits from 'Avram::Database'
app_1     |   2. Configure it with 'AppDatabase.configure'
app_1     |   3. Set the database in 'BaseModel' (can also be specific per model). Example:
app_1     |
app_1     |       class BaseModel < Avram::Model
app_1     |         def self.database
app_1     |           AppDatabase
app_1     |         end
app_1     |       end
app_1     |
app_1     |
app_1     | Avram::Repo.configure do |settings|
app_1     |             ^~~~~~~~~
app_1     |
app_1     | There was a problem compiling. Watching for fixes...

is this because I am using lucky v0.17.0-rc1? should I use v0.16.0? if so can I specify a specific version in the docker file?

@jwoertink

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

hey @robertguss thanks for tackling this. Here's the PR I did for the footer on the old site luckyframework/website-old#212 you can use for reference..

Also, as for that error, yes, this app hasn't really been updated for 0.17 support just yet. Try using 0.16 if you can.

@robertguss

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

I spent a couple hours yesterday trying to get the website/app working both with docker and without and kept running into various errors. Is there a branch that is configured to work with 0.16 that I could pull down? If not do you think a new branch could be configured to make it easy for newbies like me to contribute? Sorry but I am just getting started with Lucky.

@jwoertink

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Sorry for the issues. It's probably because we always point to master branch on everything, so it makes it a little tough sometimes.

I'll take a look at upgrading this app to ensure it's fully 0.17 supported. Once that's merged in, then you will be able to rebase from master and hopefully everything will just work for you. I'll let you know when you should be good.

@robertguss

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Thank you.

@jwoertink

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@robertguss ok, rebase, and give it another shot. You may need to clear out some docker cache stuff. For example, I had to

  • up down - ensure the docker container is stopped
  • docker image prune - remove some images I wasn't using
  • docker container prune - remove some containers I'm not using
  • rm up.cache - tell up to not use cache

You may not need to do those, but just in case you run in to a weird cache issue, it may help.

@robertguss

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Still can't get it to work with Docker or Up, but I managed to get it working locally on my mac. Good to go now.

Thank you for updating and configuring everything. I will get to work on the footer asap.

@jwoertink

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Weird. Yeah, @paulcsmith and I were talking about that earlier. Docker is fine when everything just works, but the second it doesn't it's straight crash and burn lol. Glad you got it working locally though. Once you have something up, be sure to include a screenshot with the PR if you can 😄

paulcsmith added a commit that referenced this issue Aug 14, 2019
Added footer - Issue #19 (#103)
* fixed typo in database querying guide

* fixed typo in routing and params guide

* added github, gitter & twitter svg icons

* created footer

* added footer to blog and guide layouts

* added responsive styles to footer

* removed .DS_STORE files

* used tailwind variable for footer top-border color

* added paul's suggestions

* changed footer_icon() from a macro to a method in footer.cr
@jwoertink

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Thanks @robertguss !

@jwoertink jwoertink closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.