-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add footer #19
Comments
Some things the footer had previously:
|
I can try and tackle this PR if you would like, I am a front-end dev. A couple of questions though:
|
Hey @robertguss! This would be wonderful.
And yes I think that'd resolve #28. I may want to add it somewhere else too but the footer is a great start. |
@paulcsmith having an issue when I run up:
is this because I am using lucky v0.17.0-rc1? should I use v0.16.0? if so can I specify a specific version in the docker file? |
hey @robertguss thanks for tackling this. Here's the PR I did for the footer on the old site luckyframework/website-old#212 you can use for reference.. Also, as for that error, yes, this app hasn't really been updated for 0.17 support just yet. Try using 0.16 if you can. |
I spent a couple hours yesterday trying to get the website/app working both with docker and without and kept running into various errors. Is there a branch that is configured to work with 0.16 that I could pull down? If not do you think a new branch could be configured to make it easy for newbies like me to contribute? Sorry but I am just getting started with Lucky. |
Sorry for the issues. It's probably because we always point to master branch on everything, so it makes it a little tough sometimes. I'll take a look at upgrading this app to ensure it's fully 0.17 supported. Once that's merged in, then you will be able to rebase from master and hopefully everything will just work for you. I'll let you know when you should be good. |
Thank you. |
@robertguss ok, rebase, and give it another shot. You may need to clear out some docker cache stuff. For example, I had to
You may not need to do those, but just in case you run in to a weird cache issue, it may help. |
Still can't get it to work with Docker or Up, but I managed to get it working locally on my mac. Good to go now. Thank you for updating and configuring everything. I will get to work on the footer asap. |
Weird. Yeah, @paulcsmith and I were talking about that earlier. Docker is fine when everything just works, but the second it doesn't it's straight crash and burn lol. Glad you got it working locally though. Once you have something up, be sure to include a screenshot with the PR if you can 😄 |
* fixed typo in database querying guide * fixed typo in routing and params guide * added github, gitter & twitter svg icons * created footer * added footer to blog and guide layouts * added responsive styles to footer * removed .DS_STORE files * used tailwind variable for footer top-border color * added paul's suggestions * changed footer_icon() from a macro to a method in footer.cr
Thanks @robertguss ! |
No description provided.
The text was updated successfully, but these errors were encountered: