Adds support for aeson-2.x #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! I'll merge this now if it passes CI One thing to note is that I'm not sure if I'll backport this change since I'm planning a big release for 2.0.0.0 next week (what's on master right has a couple of quite large breaking changes motivated of course by some features) The last released version of conferer-aeson is on https://github.com/ludat/conferer/tree/conferer-aeson_v1.1.0.1 so if you need the backport create a PR and I can release that |
The cabal file is autogenerated
Since it clashes with using CPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
aeson-2.xby way of a littleCPPglue and some selective module qualification.Not sure if there isn't a better way to go about this, though.
Fixes #(issue)
Related to commercialhaskell/stackage#6217
Checklist: