Providing Kong admin token via file Kong#4789

Feedback from PR review.
ludovic-pourrat · Oct 11, 2023 · 5aff8cd · 5aff8cd
1 parent 82311e1
commit 5aff8cd
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/internal/manager/config.go b/internal/manager/config.go
@@ -287,15 +287,14 @@ func (c *Config) FlagSet() *pflag.FlagSet {
 	return flagSet
 }
 
+// Resolve the Config item(s) value from file, when provided.
 func (c *Config) Resolve() error {
-	if c.KongAdminToken == "" {
-		if c.KongAdminTokenPath != "" {
-			token, err := os.ReadFile(c.KongAdminTokenPath)
-			if err != nil {
-				return fmt.Errorf("failed to read --kong-admin-token-file from path '%s': %w", c.KongAdminTokenPath, err)
-			}
-			c.KongAdminToken = string(token)
+	if c.KongAdminTokenPath != "" {
+		token, err := os.ReadFile(c.KongAdminTokenPath)
+		if err != nil {
+			return fmt.Errorf("failed to read --kong-admin-token-file from path '%s': %w", c.KongAdminTokenPath, err)
 		}
+		c.KongAdminToken = string(token)
 	}
 	return nil
 }