Fix serve.py adding a try around the form parsing #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Mar 5, 2021
ludwig/serve.py
Outdated
| form = await request.form() | ||
| files, entry = convert_input(form) | ||
| except Exception as e: | ||
| logger.error("Failed to parse batch_predict form: {}".format( |
There was a problem hiding this comment.
str(e) drops the stack trace. An easy way to log the exception would be with logger.exception:
logger.exception("Failed to parse batch_predict form")
Though since the current style also uses logger.error, no worries if you would rather stick to the file convention.
tgaddair
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.