Add dicts to initializer field types for combiners #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Nov 10, 2021
ludwig/utils/schema_utils.py
Outdated
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "type": { "type": "string" }, |
There was a problem hiding this comment.
Should type also be one of the list of initializer_registry?
ksbrar
added a commit
that referenced
this pull request
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a marshmallow field
InitializerOrDictmodeled afterEmbedandInitializerOptionsthat allows valid initializer strings or dicts with a 'type' parameter (ref - seeinitializerdescription). Setsweights_initializerandbias_initializerfields incombiners.pyto use this instead ofInitializerOptionsHaving some Torch issues locally, but hopefully tests pass here...