Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #1476 ('dict' option for weights_initializer and bias_initializer) to tf_legacy #1599

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Dec 15, 2021

@ksbrar ksbrar self-assigned this Dec 15, 2021
@github-actions
Copy link

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 59m 55s ⏱️ + 5m 10s
1 216 tests ±0  1 192 ✔️ ±0  24 💤 ±0  0 ±0 
3 648 runs  ±0  3 576 ✔️ ±0  72 💤 ±0  0 ±0 

Results for commit b203af1. ± Comparison against base commit d0d0a70.

@ksbrar
Copy link
Collaborator Author

ksbrar commented Dec 15, 2021

@justinxzhao Should I add the pre-commit.yaml file to tf-legacy as part of this PR? (it is not present otherwise)

@justinxzhao
Copy link
Collaborator

@justinxzhao Should I add the pre-commit.yaml file to tf-legacy as part of this PR? (it is not present otherwise)

Feel free to ignore the pre-commit check in this branch, since we've never fixed all of the linting/formatting errors on tf-legacy and the precommit check will always be red. I'll see if there's a way to disable precommit checking for PRs that aren't merging into master.

weights_initializer: str = schema.InitializerOptions(default='glorot_uniform')
bias_initializer: str = schema.InitializerOptions(default='zeros')
weights_initializer: Union[str, Dict] = schema.InitializerOrDict(default='glorot_uniform')
bias_initializer: Union[str, Dict] = schema.InitializerOrDict(default='zeros')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what's an example of a bias initializer configured using a dict?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a concrete example for you 😅 but it's explicity supported by the developer guide, traces to TF documentation for initializer parameters

@tgaddair tgaddair merged commit 2c31bc0 into tf-legacy Dec 16, 2021
@tgaddair tgaddair deleted the add_initializer_dict_pr branch December 16, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants