Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify combiners to accept input_features as a dict instead of a list #1618

Merged
merged 4 commits into from
Dec 22, 2021

Conversation

jeffreyftang
Copy link
Collaborator

Fixes #1617.

This is a quick patch to fix a bug specific to the tf-legacy branch. The underlying issue should already be resolved in master.

Since build_inputs outputs a dict, not a list, this PR modifies the TabTransformerCombiner to work properly with a dict. Other combiners were and should remain unaffected.

@github-actions
Copy link

github-actions bot commented Dec 21, 2021

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 45m 30s ⏱️ + 1m 44s
1 216 tests ±0  1 192 ✔️ ±0  24 💤 ±0  0 ±0 
3 648 runs  ±0  3 576 ✔️ ±0  72 💤 ±0  0 ±0 

Results for commit 357e744. ± Comparison against base commit 2c31bc0.

♻️ This comment has been updated with latest results.

@jeffreyftang jeffreyftang merged commit ef21cfe into tf-legacy Dec 22, 2021
@justinxzhao justinxzhao deleted the list-to-map branch May 23, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants