Fix redundant import #2019
Merged
Fix redundant import #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
approved these changes
May 10, 2022
ksbrar
approved these changes
May 10, 2022
justinxzhao
reviewed
May 10, 2022
| @@ -7,7 +7,7 @@ | |||
| from torch import nn, Tensor | |||
|
|
|||
| from ludwig.api import LudwigModel | |||
| from ludwig.combiners.combiners import BaseCombinerConfig, Combiner, register_combiner | |||
| from ludwig.combiners.combiners import Combiner, register_combiner | |||
There was a problem hiding this comment.
Should we delete line 18 instead?
There was a problem hiding this comment.
No, this is the correct change - BaseCombinerConfig is not exposed by ludwig.combiners.combiners
There was a problem hiding this comment.
I liked line 18 more because it's the true location of that class, as opposed to an indirect import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.